From 07251560cac3a06f7356d8b13db7abc1bbdfdf20 Mon Sep 17 00:00:00 2001 From: Simon Glass Date: Wed, 20 Jul 2011 08:12:19 +1200 Subject: Fix LCD corruptions Add missing lcd_syncs on compressed bitmap display and "echo" command. BUG=chromium-os:17779 TEST=start U-Boot; vboot; see that recovery screen is fully drawn. Change-Id: I675f2c60dc53b9e853157d3670a07e7a6c8eee3c Reviewed-on: http://gerrit.chromium.org/gerrit/4328 Tested-by: Vincent Palatin Reviewed-by: Tom Wai-Hong Tam Reviewed-by: Puneet Kumar Reviewed-by: Simon Glass --- common/cmd_echo.c | 2 +- common/lcd.c | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/common/cmd_echo.c b/common/cmd_echo.c index 43a6da57226..a9bab602e50 100644 --- a/common/cmd_echo.c +++ b/common/cmd_echo.c @@ -45,7 +45,7 @@ int do_echo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) } if (putnl) - putc('\n'); + puts("\n"); return 0; } diff --git a/common/lcd.c b/common/lcd.c index 0ea8d82b597..53093bb2675 100644 --- a/common/lcd.c +++ b/common/lcd.c @@ -696,7 +696,7 @@ static uchar *draw_encoded_bitmap(uchar *fb, ushort c, int cnt) /* Do not call this function directly, must be called from * lcd_display_bitmap. */ -static int lcd_display_rle8_bitmap(bmp_image_t *bmp, ushort *cmap, uchar *fb, +static void lcd_display_rle8_bitmap(bmp_image_t *bmp, ushort *cmap, uchar *fb, int x_off, int y_off) { uchar *bmap; @@ -779,7 +779,6 @@ static int lcd_display_rle8_bitmap(bmp_image_t *bmp, ushort *cmap, uchar *fb, bmap += 2; } } - return 0; } #endif /* CONFIG_LCD_BMP_RLE8 */ @@ -928,8 +927,8 @@ int lcd_display_bitmap(ulong bmp_image, int x, int y) printf("Error: only support 16 bpix"); return 1; } - return lcd_display_rle8_bitmap(bmp, cmap_base, fb, - x, y); + lcd_display_rle8_bitmap(bmp, cmap_base, fb, x, y); + break; } #endif -- cgit v1.2.3