From b75d8dc5642b71eb029e7cd38031a32029e736cc Mon Sep 17 00:00:00 2001 From: Masahiro Yamada Date: Fri, 26 Jun 2020 15:13:33 +0900 Subject: treewide: convert bd_t to struct bd_info by coccinelle The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include #include void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: @@ typedef bd_t; @@ -bd_t +struct bd_info Signed-off-by: Masahiro Yamada --- arch/m68k/lib/bdinfo.c | 2 +- arch/m68k/lib/bootm.c | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) (limited to 'arch/m68k/lib') diff --git a/arch/m68k/lib/bdinfo.c b/arch/m68k/lib/bdinfo.c index 971c47c3064..fb4d1a52fd4 100644 --- a/arch/m68k/lib/bdinfo.c +++ b/arch/m68k/lib/bdinfo.c @@ -13,7 +13,7 @@ DECLARE_GLOBAL_DATA_PTR; void arch_print_bdinfo(void) { - bd_t *bd = gd->bd; + struct bd_info *bd = gd->bd; #if defined(CONFIG_SYS_INIT_RAM_ADDR) bdinfo_print_num("sramstart", (ulong)bd->bi_sramstart); diff --git a/arch/m68k/lib/bootm.c b/arch/m68k/lib/bootm.c index aa17929b9ea..320451144fd 100644 --- a/arch/m68k/lib/bootm.c +++ b/arch/m68k/lib/bootm.c @@ -27,7 +27,7 @@ DECLARE_GLOBAL_DATA_PTR; #define LINUX_MAX_ARGS 256 static ulong get_sp (void); -static void set_clocks_in_mhz (bd_t *kbd); +static void set_clocks_in_mhz (struct bd_info *kbd); void arch_lmb_reserve(struct lmb *lmb) { @@ -54,8 +54,8 @@ int do_bootm_linux(int flag, int argc, char *const argv[], bootm_headers_t *images) { int ret; - bd_t *kbd; - void (*kernel) (bd_t *, ulong, ulong, ulong, ulong); + struct bd_info *kbd; + void (*kernel) (struct bd_info *, ulong, ulong, ulong, ulong); struct lmb *lmb = &images->lmb; /* @@ -79,7 +79,7 @@ int do_bootm_linux(int flag, int argc, char *const argv[], if (ret) goto error; - kernel = (void (*)(bd_t *, ulong, ulong, ulong, ulong))images->ep; + kernel = (void (*)(struct bd_info *, ulong, ulong, ulong, ulong))images->ep; debug("## Transferring control to Linux (at address %08lx) ...\n", (ulong) kernel); @@ -112,7 +112,7 @@ static ulong get_sp (void) return sp; } -static void set_clocks_in_mhz (bd_t *kbd) +static void set_clocks_in_mhz (struct bd_info *kbd) { char *s; -- cgit v1.2.3