From 21a2c129adaab04a7a032a31c816ae09375fe954 Mon Sep 17 00:00:00 2001 From: Tom Rini Date: Tue, 9 Jan 2024 17:57:16 -0500 Subject: getchar(): Correct usage The function getchar() returns an 'int' and not a 'char'. Coverity notes that "Assigning the return value of getchar to char ... truncates its value." and so for the most part we can resolve this easily by using 'int' as intended, and often used throughout the codebase. A few places are not so simple and would require further re-architecting of the code in order to change this, so we leave them be. Signed-off-by: Tom Rini --- common/cli_readline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'common/cli_readline.c') diff --git a/common/cli_readline.c b/common/cli_readline.c index 85453beed76..2507be22952 100644 --- a/common/cli_readline.c +++ b/common/cli_readline.c @@ -540,7 +540,7 @@ static int cread_line_simple(const char *const prompt, char *p) int n = 0; /* buffer index */ int plen = 0; /* prompt length */ int col; /* output column cnt */ - char c; + int c; /* print prompt */ if (prompt) { -- cgit v1.2.3