From 09140113108541b95d340f3c7b6ee597d31ccc73 Mon Sep 17 00:00:00 2001 From: Simon Glass Date: Sun, 10 May 2020 11:40:03 -0600 Subject: command: Remove the cmd_tbl_t typedef We should not use typedefs in U-Boot. They cannot be used as forward declarations which means that header files must include the full header to access them. Drop the typedef and rename the struct to remove the _s suffix which is now not useful. This requires quite a few header-file additions. Signed-off-by: Simon Glass --- common/lcd_console.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'common/lcd_console.c') diff --git a/common/lcd_console.c b/common/lcd_console.c index d34bc2fa830..ad5f307af44 100644 --- a/common/lcd_console.c +++ b/common/lcd_console.c @@ -7,6 +7,7 @@ */ #include +#include #include #include #include /* Get font data, width and height */ @@ -219,7 +220,7 @@ void lcd_printf(const char *fmt, ...) lcd_puts(buf); } -static int do_lcd_setcursor(cmd_tbl_t *cmdtp, int flag, int argc, +static int do_lcd_setcursor(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) { unsigned int col, row; @@ -234,7 +235,7 @@ static int do_lcd_setcursor(cmd_tbl_t *cmdtp, int flag, int argc, return 0; } -static int do_lcd_puts(cmd_tbl_t *cmdtp, int flag, int argc, +static int do_lcd_puts(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) { if (argc != 2) -- cgit v1.2.3 From f7ae49fc4f363a803dab3be078e93ead8e75a8e9 Mon Sep 17 00:00:00 2001 From: Simon Glass Date: Sun, 10 May 2020 11:40:05 -0600 Subject: common: Drop log.h from common header Move this header out of the common header. Signed-off-by: Simon Glass --- common/lcd_console.c | 1 + 1 file changed, 1 insertion(+) (limited to 'common/lcd_console.c') diff --git a/common/lcd_console.c b/common/lcd_console.c index ad5f307af44..1a246c492ce 100644 --- a/common/lcd_console.c +++ b/common/lcd_console.c @@ -9,6 +9,7 @@ #include #include #include +#include #include #include /* Get font data, width and height */ #if defined(CONFIG_LCD_LOGO) -- cgit v1.2.3