From 33699df12cbcd9bfa609dc7fb5a0a69c029449e9 Mon Sep 17 00:00:00 2001 From: Jerry Huang Date: Tue, 6 Nov 2012 15:33:12 +0000 Subject: part: check each variable for capability calculation In order to calculate the capability, we use the below expression to check: ((dev_desc->lba * dev_desc->blksz)>0L) If the capability is greater than 4GB (e.g. 8GB = 8 * 1024 * 104 * 1024), the result will overflow, the low 32bit may be zero. Therefore, change to check each variable to fix this potential issue. Signed-off-by: Jerry Huang --- disk/part.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'disk') diff --git a/disk/part.c b/disk/part.c index 4646f682d2c..7bdc90eff70 100644 --- a/disk/part.c +++ b/disk/part.c @@ -199,7 +199,7 @@ void dev_print (block_dev_desc_t *dev_desc) break; } puts ("\n"); - if ((dev_desc->lba * dev_desc->blksz)>0L) { + if (dev_desc->lba > 0L && dev_desc->blksz > 0L) { ulong mb, mb_quot, mb_rem, gb, gb_quot, gb_rem; lbaint_t lba; -- cgit v1.2.3