From 98c14ff019515ffcb1b40b550e56fe1dfbede51b Mon Sep 17 00:00:00 2001 From: Rasmus Villemoes Date: Wed, 19 May 2021 18:08:11 +0200 Subject: remove struct uclass_driver::ops Each _device_ belonging to a given uclass of course has its own ->ops, of a type determined by and known to the uclass. However, no instance of a uclass_driver seems to populate ->ops, and the only reference to it in code is this relocation. Moreover, it's not really clear what could sensibly be assigned; it would have to be some "struct uclass_ops *" providing a set of methods for the core to call on that particular uclass, but should the need for that ever arise, it would be better to have a member of that particular type instead of void*. Signed-off-by: Rasmus Villemoes Reviewed-by: Simon Glass --- drivers/core/root.c | 3 --- 1 file changed, 3 deletions(-) (limited to 'drivers/core/root.c') diff --git a/drivers/core/root.c b/drivers/core/root.c index 537e9daaf8a..78eee082c95 100644 --- a/drivers/core/root.c +++ b/drivers/core/root.c @@ -113,9 +113,6 @@ void fix_uclass(void) entry->init += gd->reloc_off; if (entry->destroy) entry->destroy += gd->reloc_off; - /* FIXME maybe also need to fix these ops */ - if (entry->ops) - entry->ops += gd->reloc_off; } } -- cgit v1.2.3