From 701a51e1ef6c727e7a4b5a48b8681f42a447072b Mon Sep 17 00:00:00 2001 From: Andy Yan Date: Fri, 31 May 2019 15:44:39 +0800 Subject: dm: mmc: remove unused U_BOOT_DRIVER(mmc) When look through the code, I found this bare metal drives is not used, so remove it. Signed-off-by: Andy Yan Reviewed-by: Simon Glass --- drivers/mmc/mmc-uclass.c | 4 ---- 1 file changed, 4 deletions(-) (limited to 'drivers/mmc/mmc-uclass.c') diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c index 2b146ea43c5..4a12324c6af 100644 --- a/drivers/mmc/mmc-uclass.c +++ b/drivers/mmc/mmc-uclass.c @@ -427,10 +427,6 @@ U_BOOT_DRIVER(mmc_blk) = { }; #endif /* CONFIG_BLK */ -U_BOOT_DRIVER(mmc) = { - .name = "mmc", - .id = UCLASS_MMC, -}; UCLASS_DRIVER(mmc) = { .id = UCLASS_MMC, -- cgit v1.2.3 From 6cf8a903c5e6723104b07b0fddc4a703556e558a Mon Sep 17 00:00:00 2001 From: Sam Protsenko Date: Wed, 14 Aug 2019 22:52:51 +0300 Subject: mmc: Rename timeout parameters for clarification It's quite hard to figure out time units for various function that have timeout parameters. This leads to possible errors when one forgets to convert ms to us, for example. Let's rename those parameters correspondingly to 'timeout_us' and 'timeout_ms' to prevent such issues further. While at it, add time units info as comments to struct mmc fields. This commit doesn't change the behavior, only renames parameters names. Buildman should report no changes at all. Signed-off-by: Sam Protsenko Reviewed-by: Peng Fan Reviewed-by: Igor Opaniuk --- drivers/mmc/mmc-uclass.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'drivers/mmc/mmc-uclass.c') diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c index 4a12324c6af..37c3843902d 100644 --- a/drivers/mmc/mmc-uclass.c +++ b/drivers/mmc/mmc-uclass.c @@ -47,18 +47,18 @@ int mmc_set_ios(struct mmc *mmc) return dm_mmc_set_ios(mmc->dev); } -int dm_mmc_wait_dat0(struct udevice *dev, int state, int timeout) +int dm_mmc_wait_dat0(struct udevice *dev, int state, int timeout_us) { struct dm_mmc_ops *ops = mmc_get_ops(dev); if (!ops->wait_dat0) return -ENOSYS; - return ops->wait_dat0(dev, state, timeout); + return ops->wait_dat0(dev, state, timeout_us); } -int mmc_wait_dat0(struct mmc *mmc, int state, int timeout) +int mmc_wait_dat0(struct mmc *mmc, int state, int timeout_us) { - return dm_mmc_wait_dat0(mmc->dev, state, timeout); + return dm_mmc_wait_dat0(mmc->dev, state, timeout_us); } int dm_mmc_get_wp(struct udevice *dev) -- cgit v1.2.3