From b75d8dc5642b71eb029e7cd38031a32029e736cc Mon Sep 17 00:00:00 2001 From: Masahiro Yamada Date: Fri, 26 Jun 2020 15:13:33 +0900 Subject: treewide: convert bd_t to struct bd_info by coccinelle The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include #include void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: @@ typedef bd_t; @@ -bd_t +struct bd_info Signed-off-by: Masahiro Yamada --- include/fsl_mdio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'include/fsl_mdio.h') diff --git a/include/fsl_mdio.h b/include/fsl_mdio.h index 8857d50910e..41cb73717bc 100644 --- a/include/fsl_mdio.h +++ b/include/fsl_mdio.h @@ -59,6 +59,6 @@ struct fsl_pq_mdio_info { struct tsec_mii_mng __iomem *regs; char *name; }; -int fsl_pq_mdio_init(bd_t *bis, struct fsl_pq_mdio_info *info); +int fsl_pq_mdio_init(struct bd_info *bis, struct fsl_pq_mdio_info *info); #endif /* __FSL_PHY_H__ */ -- cgit v1.2.3