diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2025-10-07 16:32:25 +0200 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2025-10-07 11:12:19 -0500 |
| commit | 0a98b40b8fe1bdebf3cb78924cef60af322c4437 (patch) | |
| tree | 74b4e15cabe6a77b98609d696b7474426616d954 | |
| parent | 61da08ecb55264fa1e2c7b8c8a630bed716edbdb (diff) | |
smb: client: Return a status code only as a constant in cifs_spnego_key_instantiate()
* Return a status code without storing it in an intermediate variable.
* Delete the local variable “ret” and the label “error”
which became unnecessary with this refactoring.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Enzo Matsumiya <ematsumiya@suse.de>
Signed-off-by: Steve French <stfrench@microsoft.com>
| -rw-r--r-- | fs/smb/client/cifs_spnego.c | 12 |
1 files changed, 3 insertions, 9 deletions
diff --git a/fs/smb/client/cifs_spnego.c b/fs/smb/client/cifs_spnego.c index 43b86fa4d695..9891f55bac1e 100644 --- a/fs/smb/client/cifs_spnego.c +++ b/fs/smb/client/cifs_spnego.c @@ -24,20 +24,14 @@ static const struct cred *spnego_cred; static int cifs_spnego_key_instantiate(struct key *key, struct key_preparsed_payload *prep) { - char *payload; - int ret; + char *payload = kmemdup(prep->data, prep->datalen, GFP_KERNEL); - ret = -ENOMEM; - payload = kmemdup(prep->data, prep->datalen, GFP_KERNEL); if (!payload) - goto error; + return -ENOMEM; /* attach the data */ key->payload.data[0] = payload; - ret = 0; - -error: - return ret; + return 0; } static void |