diff options
| author | Vincent Guittot <vincent.guittot@linaro.org> | 2025-07-08 18:56:30 +0200 |
|---|---|---|
| committer | Peter Zijlstra <peterz@infradead.org> | 2025-07-09 13:40:23 +0200 |
| commit | 0b9ca2dcabc3c8816a6ee75599cab7bef3330609 (patch) | |
| tree | e299f286c14ed0b72d791b0188822ea3318a26a4 | |
| parent | 3a0baa8e6c570c252999cb651398a88f8f990b4a (diff) | |
sched/fair: Always trigger resched at the end of a protected period
Always trigger a resched after a protected period even if the entity is
still eligible. It can happen that an entity remains eligible at the end
of the protected period but must let an entity with a shorter slice to run
in order to keep its lag shorter than slice. This is particulalry true
with run to parity which tries to maximize the lag.
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20250708165630.1948751-7-vincent.guittot@linaro.org
| -rw-r--r-- | kernel/sched/fair.c | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 1660960d64af..20a845697c1d 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -1182,14 +1182,6 @@ static inline void update_curr_task(struct task_struct *p, s64 delta_exec) cgroup_account_cputime(p, delta_exec); } -static inline bool resched_next_slice(struct cfs_rq *cfs_rq, struct sched_entity *curr) -{ - if (protect_slice(curr)) - return false; - - return !entity_eligible(cfs_rq, curr); -} - /* * Used by other classes to account runtime. */ @@ -1250,7 +1242,7 @@ static void update_curr(struct cfs_rq *cfs_rq) if (cfs_rq->nr_queued == 1) return; - if (resched || resched_next_slice(cfs_rq, curr)) { + if (resched || !protect_slice(curr)) { resched_curr_lazy(rq); clear_buddies(cfs_rq, curr); } |