diff options
| author | Jude Gyimah <jude.gyimah87@gmail.com> | 2026-11-03 14:25:33 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2026-11-03 23:26:12 +0000 |
| commit | 1c57404bf9bad3e05d5686d91c208bf4e2b733d8 (patch) | |
| tree | 43d37a9e2063d60efb4b426e45e6d61f30295403 | |
| parent | 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4 (diff) | |
ASoC: rockchip_i2s: select REGMAP_MMIO
rockchip_i2s calls __devm_regmap_init_mmio_clk, which
drivers/base/regmap/regmap-mmio.c provides under REGMAP_MMIO.
rockchip_i2s.c:(.text+0x418): undefined reference to
`__devm_regmap_init_mmio_clk'
The driver can be built into vmlinux while REGMAP_MMIO is a module, in
which case the symbol is not there at link time.
Select rather than depend on: REGMAP_MMIO has no prompt of its own and is
only ever enabled by a select, so a depends on would leave
SND_SOC_ROCKCHIP_I2S unselectable.
Reproduced on v7.3, x86_64, with CONFIG_SND_SOC_ROCKCHIP_I2S=y and
CONFIG_REGMAP_MMIO=m.
Found with kreach, a static check that compares what Kconfig allows
against the symbols the compiled objects actually reference.
Fixes: 4495c89fcf26 ("ASoC: add driver for Rockchip RK3xxx I2S controller")
Signed-off-by: Jude Gyimah <jude.gyimah87@gmail.com>
Link: https://patch.msgid.link/20261103132537.3717496-2-jude.gyimah87@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/rockchip/Kconfig | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sound/soc/rockchip/Kconfig b/sound/soc/rockchip/Kconfig index 391ce2225fde..d7ec1fbe17a5 100644 --- a/sound/soc/rockchip/Kconfig +++ b/sound/soc/rockchip/Kconfig @@ -5,6 +5,7 @@ menu "Rockchip" config SND_SOC_ROCKCHIP_I2S tristate "Rockchip I2S Device Driver" + select REGMAP_MMIO select SND_SOC_GENERIC_DMAENGINE_PCM help Say Y or M if you want to add support for I2S driver for |
