diff options
| author | Tomasz Lis <tomasz.lis@intel.com> | 2026-03-20 15:57:33 +0100 |
|---|---|---|
| committer | Matthew Brost <matthew.brost@intel.com> | 2026-03-25 18:24:52 -0700 |
| commit | 3d4939c0ec011ad6dfda7c13362b3d2013425789 (patch) | |
| tree | 7a84d139dc434524a3f2e5d07856e2609ba6706a | |
| parent | 4e966014ce8826bb7d0180394f40b643b1405925 (diff) | |
drm/xe: Fix confusion with locals on context creation
After setting a local variable, check that local value rather that
checking destination at which the value will be stored later.
This fixes the obvious mistake in error path; without it,
allocation fail would lead to NULL dereference during context
creation.
Fixes: 89340099c6a4 ("drm/xe/lrc: Refactor context init into xe_lrc_ctx_init()")
Signed-off-by: Tomasz Lis <tomasz.lis@intel.com>
Cc: Raag Jadav <raag.jadav@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Link: https://patch.msgid.link/20260320145733.1337682-1-tomasz.lis@intel.com
| -rw-r--r-- | drivers/gpu/drm/xe/xe_lrc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/xe/xe_lrc.c b/drivers/gpu/drm/xe/xe_lrc.c index 24f4c7210cfb..9d12a0d2f0b5 100644 --- a/drivers/gpu/drm/xe/xe_lrc.c +++ b/drivers/gpu/drm/xe/xe_lrc.c @@ -1630,8 +1630,8 @@ static int xe_lrc_init(struct xe_lrc *lrc, struct xe_hw_engine *hwe, struct xe_v bo = xe_bo_create_pin_map_novm(xe, tile, bo_size, ttm_bo_type_kernel, bo_flags, false); - if (IS_ERR(lrc->bo)) - return PTR_ERR(lrc->bo); + if (IS_ERR(bo)) + return PTR_ERR(bo); lrc->bo = bo; |