summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChandra Mohan Sundar <chandramohan.explore@gmail.com>2025-09-06 21:51:54 +0530
committerTakashi Iwai <tiwai@suse.de>2025-09-06 19:55:10 +0200
commit400f60b27415f927f8964dd32d1f5baa53782e5f (patch)
tree8881a80280407db1bd9c1d0e61b0ad0cb914acba
parenta73349c5dd27bc544b048e2e2c8ef6394f05b793 (diff)
ALSA: cs4281: Send the PCM period elapsed notification properly
As part of spin lock code cleanup using guard(), a new variable (period_elapsed) was introduced. However this variable is never set, causing period elapsed notification to be not sent. Set the value of period_elapsed appropiately. This issue was reported by static coverity analyzer. Fixes: 7a5127c2c8a5a ("ALSA: cs4281: Use guard() for spin locks") Signed-off-by: Chandra Mohan Sundar <chandramohan.explore@gmail.com> Link: https://patch.msgid.link/20250906162158.564899-1-chandramohan.explore@gmail.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/pci/cs4281.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/sound/pci/cs4281.c b/sound/pci/cs4281.c
index c519fb9cdd1e..d00b2c9fb1e3 100644
--- a/sound/pci/cs4281.c
+++ b/sound/pci/cs4281.c
@@ -1752,6 +1752,7 @@ static irqreturn_t snd_cs4281_interrupt(int irq, void *dev_id)
chip->spurious_dtc_irq++;
continue;
}
+ period_elapsed = true;
}
if (period_elapsed)
snd_pcm_period_elapsed(cdma->substream);