diff options
| author | Qianfeng Rong <rongqianfeng@vivo.com> | 2025-08-29 21:37:48 +0800 |
|---|---|---|
| committer | Mikulas Patocka <mpatocka@redhat.com> | 2025-09-02 11:19:12 +0200 |
| commit | 4466dd3d719cca113308e8ae539adf7b3d68c985 (patch) | |
| tree | 457a3e72d326fdcf8da6aad788c50884db8266b4 | |
| parent | 9f5c33bdddcdb1d83a38cb3ff405dba8c9fde9b8 (diff) | |
dm-pcache: use int type to store negative error codes
Change the 'ret' variable from u32 to int to store negative error codes or
zero returned by cache_kset_close().
Storing the negative error codes in unsigned type, doesn't cause an issue
at runtime but it's ugly. Additionally, assigning negative error codes to
unsigned type may trigger a GCC warning when the -Wsign-conversion flag
is enabled.
No effect on runtime.
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
| -rw-r--r-- | drivers/md/dm-pcache/cache_req.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/md/dm-pcache/cache_req.c b/drivers/md/dm-pcache/cache_req.c index bd5cace7de71..27f94c1fa968 100644 --- a/drivers/md/dm-pcache/cache_req.c +++ b/drivers/md/dm-pcache/cache_req.c @@ -805,7 +805,8 @@ err: int cache_flush(struct pcache_cache *cache) { struct pcache_cache_kset *kset; - u32 i, ret; + int ret; + u32 i; for (i = 0; i < cache->n_ksets; i++) { kset = get_kset(cache, i); |