summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChenghao Duan <duanchenghao@kylinos.cn>2026-03-26 16:47:22 +0800
committerAndrew Morton <akpm@linux-foundation.org>2026-04-18 00:10:52 -0700
commit502d3c2ad8f05d1545ae05f96f71a5916aa88b0f (patch)
treead62ef28005857af3baed9773e3ee9477dabacd8
parented2a29dc6dcf4630ef19d588704c2ca7b46607bb (diff)
mm/memfd_luo: optimize shmem_recalc_inode calls in retrieve path
Move shmem_recalc_inode() out of the loop in memfd_luo_retrieve_folios() to improve performance when restoring large memfds. Currently, shmem_recalc_inode() is called for each folio during restore, which is O(n) expensive operations. This patch collects the number of successfully added folios and calls shmem_recalc_inode() once after the loop completes, reducing complexity to O(1). Additionally, fix the error path to also call shmem_recalc_inode() for the folios that were successfully added before the error occurred. Link: https://lore.kernel.org/20260326084727.118437-3-duanchenghao@kylinos.cn Signed-off-by: Chenghao Duan <duanchenghao@kylinos.cn> Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com> Reviewed-by: Pratyush Yadav <pratyush@kernel.org> Cc: Haoran Jiang <jianghaoran@kylinos.cn> Cc: Mike Rapoport (Microsoft) <rppt@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
-rw-r--r--mm/memfd_luo.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/mm/memfd_luo.c b/mm/memfd_luo.c
index ec4c3e1e2891..865b044bee62 100644
--- a/mm/memfd_luo.c
+++ b/mm/memfd_luo.c
@@ -410,7 +410,7 @@ static int memfd_luo_retrieve_folios(struct file *file,
struct inode *inode = file_inode(file);
struct address_space *mapping = inode->i_mapping;
struct folio *folio;
- long npages;
+ long npages, nr_added_pages = 0;
int err = -EIO;
long i;
@@ -465,12 +465,14 @@ static int memfd_luo_retrieve_folios(struct file *file,
goto unlock_folio;
}
- shmem_recalc_inode(inode, npages, 0);
+ nr_added_pages += npages;
folio_add_lru(folio);
folio_unlock(folio);
folio_put(folio);
}
+ shmem_recalc_inode(inode, nr_added_pages, 0);
+
return 0;
unlock_folio:
@@ -489,6 +491,8 @@ put_folios:
folio_put(folio);
}
+ shmem_recalc_inode(inode, nr_added_pages, 0);
+
return err;
}