summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMary Strodl <mstrodl@csh.rit.edu>2025-10-14 09:35:27 -0400
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>2025-10-21 14:10:45 +0200
commit523ebae1cdcf8056dfe090f31284d1e5f5d1b73f (patch)
tree989028a802cb9f15000ca54d096e98ecc543e8c1
parent0efa5b2ca6fa7baab4c523b34cfb9495ec143d61 (diff)
gpio: mpsse: propagate error from direction_input
Not sure how I missed this, but errors encountered when setting the direction to input weren't being propagated to the caller. Signed-off-by: Mary Strodl <mstrodl@csh.rit.edu> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Link: https://lore.kernel.org/r/20251014133530.3592716-2-mstrodl@csh.rit.edu Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
-rw-r--r--drivers/gpio/gpio-mpsse.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/gpio/gpio-mpsse.c b/drivers/gpio/gpio-mpsse.c
index 9f42bb30b4ec..c508d9e33054 100644
--- a/drivers/gpio/gpio-mpsse.c
+++ b/drivers/gpio/gpio-mpsse.c
@@ -261,9 +261,8 @@ static int gpio_mpsse_direction_input(struct gpio_chip *chip,
guard(mutex)(&priv->io_mutex);
priv->gpio_dir[bank] &= ~BIT(bank_offset);
- gpio_mpsse_set_bank(priv, bank);
- return 0;
+ return gpio_mpsse_set_bank(priv, bank);
}
static int gpio_mpsse_get_direction(struct gpio_chip *chip,