diff options
| author | Kaushlendra Kumar <kaushlendra.kumar@intel.com> | 2025-08-28 12:00:00 +0530 |
|---|---|---|
| committer | Shuah Khan <skhan@linuxfoundation.org> | 2025-09-16 16:21:50 -0600 |
| commit | 57b100d4cf14276e0340eecb561005c07c129eb8 (patch) | |
| tree | 62055f7ef1615efbf52a93a10488fade863eb33d | |
| parent | f83ec76bf285bea5727f478a68b894f5543ca76e (diff) | |
tools/cpupower: fix error return value in cpupower_write_sysfs()
The cpupower_write_sysfs() function currently returns -1 on
write failure, but the function signature indicates it should
return an unsigned int. Returning -1 from an unsigned function
results in a large positive value rather than indicating
an error condition.
Fix this by returning 0 on failure, which is more appropriate
for an unsigned return type and maintains consistency with typical
success/failure semantics where 0 indicates failure and non-zero
indicates success (bytes written).
Link: https://lore.kernel.org/r/20250828063000.803229-1-kaushlendra.kumar@intel.com
Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
| -rw-r--r-- | tools/power/cpupower/lib/cpupower.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/power/cpupower/lib/cpupower.c b/tools/power/cpupower/lib/cpupower.c index ce8dfb8e46ab..d7f7ec6f151c 100644 --- a/tools/power/cpupower/lib/cpupower.c +++ b/tools/power/cpupower/lib/cpupower.c @@ -56,7 +56,7 @@ unsigned int cpupower_write_sysfs(const char *path, char *buf, size_t buflen) if (numwritten < 1) { perror(path); close(fd); - return -1; + return 0; } close(fd); |