diff options
| author | Chen Ridong <chenridong@huawei.com> | 2025-09-19 01:12:27 +0000 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2025-09-19 06:41:26 -1000 |
| commit | 59d5de3655698679ad8fd2cc82228de4679c4263 (patch) | |
| tree | 761f8e9c9a7a26995efc5ae06eeceac19d0dbcf9 | |
| parent | 216217ebee16afc4d79c3e86a736d87175c18e68 (diff) | |
cpuset: Use new excpus for nocpu error check when enabling root partition
A previous patch fixed a bug where new_prs should be assigned before
checking housekeeping conflicts. This patch addresses another potential
issue: the nocpu error check currently uses the xcpus which is not updated.
Although no issue has been observed so far, the check should be performed
using the new effective exclusive cpus.
The comment has been removed because the function returns an error if
nocpu checking fails, which is unrelated to the parent.
Signed-off-by: Chen Ridong <chenridong@huawei.com>
Reviewed-by: Waiman Long <longman@redhat.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
| -rw-r--r-- | kernel/cgroup/cpuset.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index 2b7e2f17577e..44d65890326a 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -1818,11 +1818,7 @@ static int update_parent_effective_cpumask(struct cpuset *cs, int cmd, if (prstate_housekeeping_conflict(new_prs, xcpus)) return PERR_HKEEPING; - /* - * A parent can be left with no CPU as long as there is no - * task directly associated with the parent partition. - */ - if (nocpu) + if (tasks_nocpu_error(parent, cs, xcpus)) return PERR_NOCPUS; /* |