diff options
| author | Gregory CLEMENT <gregory.clement@bootlin.com> | 2026-01-07 14:04:52 +0100 |
|---|---|---|
| committer | Rob Herring (Arm) <robh@kernel.org> | 2026-02-03 20:58:12 -0600 |
| commit | 5dff92a7bde9a8ef3b709f65e347cb1c33260cf4 (patch) | |
| tree | 42ee2ca5876b1154ff28cdff058ca7ec5e5c41bf | |
| parent | 0365adafdb9bb9f7b5dc6793a8db3854beac0a94 (diff) | |
of: reserved_mem: Fix placement of __free() annotation
The __free() annotation was incorrectly placed before the variable
name instead of after it, which resulted in the following checkpatch
errors:
ERROR: need consistent spacing around '*' (ctx:WxV)
+ struct device_node __free(device_node) *target = of_parse_phandle(np, "memory-region", idx);
^
WARNING: function definition argument 'idx' should also have an identifier name
+ struct device_node __free(device_node) *target = of_parse_phandle(np, "memory-region", idx);
As part of this cleanup, also remove the useless return statement
flagged by checkpatch.
Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Link: https://patch.msgid.link/20260107-mtd-memregion-v3-1-f9fc9107b992@bootlin.com
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
| -rw-r--r-- | drivers/of/of_reserved_mem.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c index 5619ec917858..1ab8f4153600 100644 --- a/drivers/of/of_reserved_mem.c +++ b/drivers/of/of_reserved_mem.c @@ -127,7 +127,6 @@ static void __init fdt_reserved_mem_save_node(unsigned long node, const char *un fdt_init_reserved_mem_node(rmem); reserved_mem_count++; - return; } static int __init early_init_dt_reserve_memory(phys_addr_t base, @@ -747,7 +746,7 @@ int of_reserved_mem_region_to_resource(const struct device_node *np, if (!np) return -EINVAL; - struct device_node __free(device_node) *target = of_parse_phandle(np, "memory-region", idx); + struct device_node *target __free(device_node) = of_parse_phandle(np, "memory-region", idx); if (!target || !of_device_is_available(target)) return -ENODEV; |