diff options
| author | Jared Kangas <jkangas@redhat.com> | 2025-11-11 13:54:12 -0800 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2025-11-18 23:56:11 +0100 |
| commit | 6010d4d8b55b5d3ae1efb5502c54312e15c14f21 (patch) | |
| tree | 7caa4c9ce93bcfd9c170c3f47d1f448fc58a8b27 | |
| parent | 97ea34defbb57bfaf71ce487b1b0865ffd186e81 (diff) | |
pinctrl: s32cc: initialize gpio_pin_config::list after kmalloc()
s32_pmx_gpio_request_enable() does not initialize the newly-allocated
gpio_pin_config::list before adding it to s32_pinctrl::gpio_configs.
This could result in a linked list corruption.
Initialize the new list_head with INIT_LIST_HEAD() to fix this.
Fixes: fd84aaa8173d ("pinctrl: add NXP S32 SoC family support")
Signed-off-by: Jared Kangas <jkangas@redhat.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
| -rw-r--r-- | drivers/pinctrl/nxp/pinctrl-s32cc.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/pinctrl/nxp/pinctrl-s32cc.c b/drivers/pinctrl/nxp/pinctrl-s32cc.c index 51ecb8d0fb7e..35511f83d056 100644 --- a/drivers/pinctrl/nxp/pinctrl-s32cc.c +++ b/drivers/pinctrl/nxp/pinctrl-s32cc.c @@ -392,6 +392,7 @@ static int s32_pmx_gpio_request_enable(struct pinctrl_dev *pctldev, gpio_pin->pin_id = offset; gpio_pin->config = config; + INIT_LIST_HEAD(&gpio_pin->list); spin_lock_irqsave(&ipctl->gpio_configs_lock, flags); list_add(&gpio_pin->list, &ipctl->gpio_configs); |