diff options
| author | Steven Rostedt <rostedt@goodmis.org> | 2026-11-18 12:25:20 -0500 |
|---|---|---|
| committer | Steven Rostedt <rostedt@goodmis.org> | 2026-11-20 10:02:38 -0500 |
| commit | 761a77e09577bc7e5fdaff1d11bbff3486a87bf9 (patch) | |
| tree | 213009feecd06d505f8d1320520364c03bf3262b | |
| parent | 2891516d90b4dc9d41aa55fde08882e40c7c0336 (diff) | |
tracing: Do not allow user events to add a system name
User events currently do not support the addition of a system name, but
the parsing does not check to see if one is specified.
A kprobe can add its own system name with the following command:
~# echo 'p:mysystem/kprobe_event schedule a=%ax' >> dynamic_events
~# ls events/mysystem
enable filter kprobe_event
But if one tries to do the same with user events:
~# echo 'u:user_events/test u32 a' >> dynamic_events
~# ls events/user_events
ls: reading directory 'events/user_events/': Invalid argument
enable filter
It corrupts the file system as the event added had a '/' in the name.
Until user events support specifying system names, just return -EINVAL to
prevent the corrupted file system from happening:
~# echo 'u:user_events/test u32 a' >> dynamic_events
-bash: echo: write error: Invalid argument
Cc: stable@vger.kernel.org
Link: https://patch.msgid.link/20261118122520.4a689710@gandalf.local.home
Acked-by: Beau Belgrave <beaub@linux.microsoft.com>
Fixes: 7f5a08c79df35 ("user_events: Add minimal support for trace_event into ftrace")
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
| -rw-r--r-- | kernel/trace/trace_events_user.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c index ea6a20a30cf5..e29e1c772aa7 100644 --- a/kernel/trace/trace_events_user.c +++ b/kernel/trace/trace_events_user.c @@ -1040,6 +1040,9 @@ static int user_event_parse_cmd(struct user_event_group *group, if (flags) *flags++ = '\0'; + if (strstr(name, "/") != NULL) + return -EINVAL; + return user_event_parse(group, name, args, flags, newuser, reg_flags); } |
