summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVille Syrjälä <ville.syrjala@linux.intel.com>2026-02-26 12:07:23 +0200
committerVille Syrjälä <ville.syrjala@linux.intel.com>2026-02-27 10:41:34 +0200
commit7e3517dfb6933214c00afdfb6fe8fab1ae000aab (patch)
treeef7fba2c3efba850d21bc0857e590fec3c33ad70
parent38d9a352c45e6d1d2a42ce173f04b43892d72eb2 (diff)
drm/i915/overlay: Remove redundant overlay->active
Now that we have overlay->frontbuffer_bits, overlay->active is completely redundant, so remove it. Reviewed-by: Jani Nikula <jani.nikula@intel.com> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patch.msgid.link/20260226100738.29997-5-ville.syrjala@linux.intel.com
-rw-r--r--drivers/gpu/drm/i915/display/intel_overlay.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/gpu/drm/i915/display/intel_overlay.c b/drivers/gpu/drm/i915/display/intel_overlay.c
index 5831af146b14..b2458840dfc4 100644
--- a/drivers/gpu/drm/i915/display/intel_overlay.c
+++ b/drivers/gpu/drm/i915/display/intel_overlay.c
@@ -194,7 +194,6 @@ struct intel_overlay {
struct i915_vma *vma;
struct i915_vma *old_vma;
struct intel_frontbuffer *frontbuffer;
- bool active;
bool pfit_active;
u32 pfit_vscale_ratio; /* shifted-point number, (1<<12) == 1.0 */
u32 color_key:24;
@@ -260,7 +259,7 @@ static bool i915_overlay_is_active(struct drm_device *drm)
struct intel_display *display = to_intel_display(drm);
struct intel_overlay *overlay = display->overlay;
- return overlay->active;
+ return overlay->frontbuffer_bits;
}
/* overlay needs to be disable in OCMD reg */
@@ -283,7 +282,6 @@ static int intel_overlay_on(struct intel_overlay *overlay,
return PTR_ERR(cs);
}
- overlay->active = true;
overlay->frontbuffer_bits = frontbuffer_bits;
if (display->platform.i830)
@@ -392,7 +390,6 @@ static void intel_overlay_off_tail(struct intel_overlay *overlay)
intel_overlay_release_old_vma(overlay);
- overlay->active = false;
overlay->frontbuffer_bits = 0;
if (display->platform.i830)
@@ -514,7 +511,6 @@ void intel_overlay_reset(struct intel_display *display)
overlay->old_xscale = 0;
overlay->old_yscale = 0;
overlay->crtc = NULL;
- overlay->active = false;
overlay->frontbuffer_bits = 0;
}