diff options
| author | Chen Ni <nichen@iscas.ac.cn> | 2026-05-06 12:14:13 +0800 |
|---|---|---|
| committer | Thomas Gleixner <tglx@kernel.org> | 2026-05-06 09:13:12 +0200 |
| commit | 8b9db67396105f6b95bcc57a354e50ac20705704 (patch) | |
| tree | aa33dae7ea4ed134aef931271d24146d84ac231c | |
| parent | 76841b0ea8be9309f6f9d2f7cf0dbac3af9ec361 (diff) | |
irqchip/starfive: Fix error check for devm_platform_ioremap_resource()
devm_platform_ioremap_resource() returns an error pointer on failure, not
NULL.
Fix the check to use IS_ERR() and return PTR_ERR() to correctly handle
allocation failures.
Fixes: 2f59ca185497 ("irqchip/starfive: Use devm_ interfaces to simplify resource release")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Reviewed-by: Changhuang Liang <changhuang.liang@starfivetech.com>
Link: https://patch.msgid.link/20260506041413.1670799-1-nichen@iscas.ac.cn
| -rw-r--r-- | drivers/irqchip/irq-starfive-jhb100-intc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/irqchip/irq-starfive-jhb100-intc.c b/drivers/irqchip/irq-starfive-jhb100-intc.c index 0d5914813afd..838885b02f34 100644 --- a/drivers/irqchip/irq-starfive-jhb100-intc.c +++ b/drivers/irqchip/irq-starfive-jhb100-intc.c @@ -208,8 +208,8 @@ static int starfive_intc_probe(struct platform_device *pdev, struct device_node return -ENOMEM; irqc->base = devm_platform_ioremap_resource(pdev, 0); - if (!irqc->base) - return dev_err_probe(&pdev->dev, -ENXIO, "unable to map registers\n"); + if (IS_ERR(irqc->base)) + return dev_err_probe(&pdev->dev, PTR_ERR(irqc->base), "unable to map registers\n"); rst = devm_reset_control_get_optional_exclusive_deasserted(&pdev->dev, NULL); if (IS_ERR(rst)) |