diff options
| author | Alexey Velichayshiy <a.velichayshiy@ispras.ru> | 2025-12-10 16:51:33 +0300 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2025-12-14 18:35:56 -0600 |
| commit | 8dd2e58b62731a96e276ee0545fb910ffb2057d9 (patch) | |
| tree | b294cf76b3e1844731c847b6a96247817d7b87e6 | |
| parent | 0446356e9f29d81757dc64ae7c61743e28d91ac0 (diff) | |
ksmbd: remove redundant DACL check in smb_check_perm_dacl
A zero value of pdacl->num_aces is already handled at the start of
smb_check_perm_dacl() so the second check is useless.
Drop the unreachable code block, no functional impact intended.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Alexey Velichayshiy <a.velichayshiy@ispras.ru>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
| -rw-r--r-- | fs/smb/server/smbacl.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/fs/smb/server/smbacl.c b/fs/smb/server/smbacl.c index 5aa7a66334d9..05598d994a68 100644 --- a/fs/smb/server/smbacl.c +++ b/fs/smb/server/smbacl.c @@ -1307,9 +1307,6 @@ int smb_check_perm_dacl(struct ksmbd_conn *conn, const struct path *path, granted |= le32_to_cpu(ace->access_req); ace = (struct smb_ace *)((char *)ace + le16_to_cpu(ace->size)); } - - if (!pdacl->num_aces) - granted = GENERIC_ALL_FLAGS; } if (!uid) |