diff options
| author | Thorsten Blum <blum@kernel.org> | 2026-09-14 10:15:01 +0200 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2026-09-23 18:38:39 +1000 |
| commit | b7e0a9bd8086eb687b647a7c9a3635a3da40977d (patch) | |
| tree | a4a8fe41164a460be81429c912900eb354a1a140 | |
| parent | 82c11f6b1241942c6e09deb85754a4e74a3ef4ec (diff) | |
crypto: powerpc/vmx - clean up includes, metadata, and p8_init()
In p8_init(), remove the goto statement and return ret directly.
Remove any redundant includes, add a missing space in MODULE_AUTHOR(),
and join the MODULE_DESCRIPTION() strings for better grepability.
Also remove MODULE_VERSION(). It has never been updated and the kernel
release better reflects the module version.
Signed-off-by: Thorsten Blum <blum@kernel.org>
Reviewed-by: Breno Leitao <leitao@debian.org>
Tested-by: Srish Srinivasan <ssrish@linux.ibm.com>
Reviewed-by: Sudhakar Kuppusamy <sudhakar@linux.ibm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
| -rw-r--r-- | arch/powerpc/crypto/vmx.c | 14 |
1 files changed, 3 insertions, 11 deletions
diff --git a/arch/powerpc/crypto/vmx.c b/arch/powerpc/crypto/vmx.c index 08da5311dfdf..8abc4db8ee4e 100644 --- a/arch/powerpc/crypto/vmx.c +++ b/arch/powerpc/crypto/vmx.c @@ -8,12 +8,7 @@ */ #include <linux/module.h> -#include <linux/moduleparam.h> -#include <linux/types.h> -#include <linux/err.h> #include <linux/cpufeature.h> -#include <linux/crypto.h> -#include <asm/cputable.h> #include <crypto/internal/skcipher.h> #include "aesp8-ppc.h" @@ -24,7 +19,7 @@ static int __init p8_init(void) ret = crypto_register_skcipher(&p8_aes_cbc_alg); if (ret) - goto err; + return ret; ret = crypto_register_skcipher(&p8_aes_ctr_alg); if (ret) @@ -40,7 +35,6 @@ err_unregister_aes_ctr: crypto_unregister_skcipher(&p8_aes_ctr_alg); err_unregister_aes_cbc: crypto_unregister_skcipher(&p8_aes_cbc_alg); -err: return ret; } @@ -54,8 +48,6 @@ static void __exit p8_exit(void) module_cpu_feature_match(PPC_MODULE_FEATURE_VEC_CRYPTO, p8_init); module_exit(p8_exit); -MODULE_AUTHOR("Marcelo Cerri<mhcerri@br.ibm.com>"); -MODULE_DESCRIPTION("IBM VMX cryptographic acceleration instructions " - "support on Power 8"); +MODULE_AUTHOR("Marcelo Cerri <mhcerri@br.ibm.com>"); +MODULE_DESCRIPTION("IBM VMX cryptographic acceleration instructions support on Power 8"); MODULE_LICENSE("GPL"); -MODULE_VERSION("1.0.0"); |