diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2025-12-20 11:45:40 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2025-12-22 09:02:04 +0000 |
| commit | c6bca73d699cfe00d3419566fdb2a45e112f44b0 (patch) | |
| tree | 89f6a9b687fbead08dbbe161d5db3b74b72c39c9 | |
| parent | 9e692bb5412a7b0e6534ba2d7158a57ed4b00658 (diff) | |
ASoC: rt1320: Fix retry checking in rt1320_rae_load()
This loop iterates 200 times and then gives up. The problem is that
currently the loop exits with "retry" set to -1 on the failure path but
the check for failure expects it to be 0. Change from a post-op to a
pre-op so that it exits with "retry" set to 0.
Fixes: 22937af75abb ("ASoC: rt1320: support RAE parameters loading")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Shuming Fan <shumingf@realtek.com>
Link: https://patch.msgid.link/aUZiNJ7pzuahXFYE@stanley.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/codecs/rt1320-sdw.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/codecs/rt1320-sdw.c b/sound/soc/codecs/rt1320-sdw.c index 00eb79204835..e1c4a1adacff 100644 --- a/sound/soc/codecs/rt1320-sdw.c +++ b/sound/soc/codecs/rt1320-sdw.c @@ -1478,7 +1478,7 @@ static int rt1320_rae_load(struct rt1320_sdw_priv *rt1320) /* RAE stop & CRC disable */ regmap_update_bits(rt1320->regmap, 0xe803, 0xbc, 0x00); - while (retry--) { + while (--retry) { regmap_read(rt1320->regmap, 0xe83f, &value); if (value & 0x40) break; |