diff options
| author | Johan Hovold <johan@kernel.org> | 2025-09-25 17:02:19 +0200 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2025-11-06 14:03:32 +0000 |
| commit | ccb7cd3218e48665f3c7e19eede0da5f069c323d (patch) | |
| tree | 7dddb35194c1761379437d5c9fa4448f6a2795ae | |
| parent | d306cbbc34cc9aa6ed2235472110fe797f887db7 (diff) | |
mfd: altera-sysmgr: Fix device leak on sysmgr regmap lookup
Make sure to drop the reference taken to the sysmgr platform device when
retrieving its driver data.
Note that holding a reference to a device does not prevent its driver
data from going away.
Fixes: f36e789a1f8d ("mfd: altera-sysmgr: Add SOCFPGA System Manager")
Cc: stable@vger.kernel.org # 5.2
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Lee Jones <lee@kernel.org>
| -rw-r--r-- | drivers/mfd/altera-sysmgr.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/mfd/altera-sysmgr.c b/drivers/mfd/altera-sysmgr.c index fb5f988e61f3..90c6902d537d 100644 --- a/drivers/mfd/altera-sysmgr.c +++ b/drivers/mfd/altera-sysmgr.c @@ -117,6 +117,8 @@ struct regmap *altr_sysmgr_regmap_lookup_by_phandle(struct device_node *np, sysmgr = dev_get_drvdata(dev); + put_device(dev); + return sysmgr->regmap; } EXPORT_SYMBOL_GPL(altr_sysmgr_regmap_lookup_by_phandle); |