diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2026-06-20 21:23:14 +0200 |
|---|---|---|
| committer | Thierry Reding <treding@nvidia.com> | 2026-06-22 08:46:25 +0200 |
| commit | e60d3f9b4c89ffff5472ddc2829d5e29bcb153fe (patch) | |
| tree | 1321b089d9ccb580930c9cada92766d8fcd5c84c | |
| parent | 2cee7da9743396aff1fd13124109c78975c92ad8 (diff) | |
drm/tegra: Fix a strange error handling path
The resource freed at the 'put_aux' label is "sor->aux->dev".
However, this resource is taken after devm_tegra_pmc_get(), so there is no
point to release it in this error handling path.
This is harmless because put_device() will be called with a NULL pointer,
but this is confusing.
So, fix the logic and return directly.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Thierry Reding <treding@nvidia.com>
| -rw-r--r-- | drivers/gpu/drm/tegra/sor.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c index a76095838133..6479f852e16a 100644 --- a/drivers/gpu/drm/tegra/sor.c +++ b/drivers/gpu/drm/tegra/sor.c @@ -3733,10 +3733,8 @@ static int tegra_sor_probe(struct platform_device *pdev) sor->num_settings = sor->soc->num_settings; sor->pmc = devm_tegra_pmc_get(&pdev->dev); - if (IS_ERR(sor->pmc)) { - err = PTR_ERR(sor->pmc); - goto put_aux; - } + if (IS_ERR(sor->pmc)) + return PTR_ERR(sor->pmc); np = of_parse_phandle(pdev->dev.of_node, "nvidia,dpaux", 0); if (np) { |