diff options
| author | Oleg Nesterov <oleg@redhat.com> | 2026-10-11 17:13:16 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2026-10-12 10:19:52 -0600 |
| commit | e889b0e4cafddb3d68c3595dc01b7128fd35fbef (patch) | |
| tree | bcfd01f47103a5779d2ac284197c4138b136dba0 | |
| parent | 37c3cab82dd6d3d315dc76d0eeeefdbc97a75f92 (diff) | |
io_uring/io-wq: don't call try_to_wake_up() twice in io_wq_worker_wake()
io_wq_worker_wake() does an unconditional wake_up_process(). This means
that __set_notify_signal() makes no real sense. Change it to use
set_tsk_thread_flag(TIF_NOTIFY_SIGNAL) instead to avoid test_and_set_bit()
and another wake_up_state(TASK_INTERRUPTIBLE) if NOTIFY_SIGNAL was not set.
Perhaps io_wq_worker_wake() can rely on __set_notify_signal() solely, but I
don't understand this code enough and this patch doesn't change the current
behaviour.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: Christian Brauner (Amutable) <brauner@kernel.org>
Link: https://patch.msgid.link/asunjCm5Ovj_YDSp@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | io_uring/io-wq.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/io_uring/io-wq.c b/io_uring/io-wq.c index 2dadde0ca395..97523ccc7a71 100644 --- a/io_uring/io-wq.c +++ b/io_uring/io-wq.c @@ -976,7 +976,7 @@ static void io_wq_for_each_worker(struct io_wq *wq, static bool io_wq_worker_wake(struct io_worker *worker, void *data) { - __set_notify_signal(worker->task); + set_tsk_thread_flag(worker->task, TIF_NOTIFY_SIGNAL); wake_up_process(worker->task); return false; } |