summaryrefslogtreecommitdiff
path: root/drivers/accel/rocket
diff options
context:
space:
mode:
authorKees Cook <kees@kernel.org>2026-02-20 23:49:23 -0800
committerKees Cook <kees@kernel.org>2026-02-21 01:02:28 -0800
commit69050f8d6d075dc01af7a5f2f550a8067510366f (patch)
treebb265f94d9dfa7876c06a5d9f88673d496a15341 /drivers/accel/rocket
parentd39a1d7486d98668dd34aaa6732aad7977c45f5a (diff)
treewide: Replace kmalloc with kmalloc_obj for non-scalar types
This is the result of running the Coccinelle script from scripts/coccinelle/api/kmalloc_objs.cocci. The script is designed to avoid scalar types (which need careful case-by-case checking), and instead replace kmalloc-family calls that allocate struct or union object instances: Single allocations: kmalloc(sizeof(TYPE), ...) are replaced with: kmalloc_obj(TYPE, ...) Array allocations: kmalloc_array(COUNT, sizeof(TYPE), ...) are replaced with: kmalloc_objs(TYPE, COUNT, ...) Flex array allocations: kmalloc(struct_size(PTR, FAM, COUNT), ...) are replaced with: kmalloc_flex(*PTR, FAM, COUNT, ...) (where TYPE may also be *VAR) The resulting allocations no longer return "void *", instead returning "TYPE *". Signed-off-by: Kees Cook <kees@kernel.org>
Diffstat (limited to 'drivers/accel/rocket')
-rw-r--r--drivers/accel/rocket/rocket_drv.c4
-rw-r--r--drivers/accel/rocket/rocket_gem.c2
-rw-r--r--drivers/accel/rocket/rocket_job.c14
3 files changed, 10 insertions, 10 deletions
diff --git a/drivers/accel/rocket/rocket_drv.c b/drivers/accel/rocket/rocket_drv.c
index e4cb2efeb55a..f09c3800ab31 100644
--- a/drivers/accel/rocket/rocket_drv.c
+++ b/drivers/accel/rocket/rocket_drv.c
@@ -38,7 +38,7 @@ rocket_iommu_domain_destroy(struct kref *kref)
static struct rocket_iommu_domain*
rocket_iommu_domain_create(struct device *dev)
{
- struct rocket_iommu_domain *domain = kmalloc(sizeof(*domain), GFP_KERNEL);
+ struct rocket_iommu_domain *domain = kmalloc_obj(*domain, GFP_KERNEL);
void *err;
if (!domain)
@@ -79,7 +79,7 @@ rocket_open(struct drm_device *dev, struct drm_file *file)
if (!try_module_get(THIS_MODULE))
return -EINVAL;
- rocket_priv = kzalloc(sizeof(*rocket_priv), GFP_KERNEL);
+ rocket_priv = kzalloc_obj(*rocket_priv, GFP_KERNEL);
if (!rocket_priv) {
ret = -ENOMEM;
goto err_put_mod;
diff --git a/drivers/accel/rocket/rocket_gem.c b/drivers/accel/rocket/rocket_gem.c
index 624c4ecf5a34..3808dfc97916 100644
--- a/drivers/accel/rocket/rocket_gem.c
+++ b/drivers/accel/rocket/rocket_gem.c
@@ -48,7 +48,7 @@ struct drm_gem_object *rocket_gem_create_object(struct drm_device *dev, size_t s
{
struct rocket_gem_object *obj;
- obj = kzalloc(sizeof(*obj), GFP_KERNEL);
+ obj = kzalloc_obj(*obj, GFP_KERNEL);
if (!obj)
return ERR_PTR(-ENOMEM);
diff --git a/drivers/accel/rocket/rocket_job.c b/drivers/accel/rocket/rocket_job.c
index acd606160dc9..518dd5779016 100644
--- a/drivers/accel/rocket/rocket_job.c
+++ b/drivers/accel/rocket/rocket_job.c
@@ -45,7 +45,7 @@ static struct dma_fence *rocket_fence_create(struct rocket_core *core)
{
struct dma_fence *fence;
- fence = kzalloc(sizeof(*fence), GFP_KERNEL);
+ fence = kzalloc_obj(*fence, GFP_KERNEL);
if (!fence)
return ERR_PTR(-ENOMEM);
@@ -71,7 +71,7 @@ rocket_copy_tasks(struct drm_device *dev,
if (!rjob->task_count)
return 0;
- rjob->tasks = kvmalloc_array(job->task_count, sizeof(*rjob->tasks), GFP_KERNEL);
+ rjob->tasks = kvmalloc_objs(*rjob->tasks, job->task_count, GFP_KERNEL);
if (!rjob->tasks) {
drm_dbg(dev, "Failed to allocate task array\n");
return -ENOMEM;
@@ -496,9 +496,9 @@ void rocket_job_fini(struct rocket_core *core)
int rocket_job_open(struct rocket_file_priv *rocket_priv)
{
struct rocket_device *rdev = rocket_priv->rdev;
- struct drm_gpu_scheduler **scheds = kmalloc_array(rdev->num_cores,
- sizeof(*scheds),
- GFP_KERNEL);
+ struct drm_gpu_scheduler **scheds = kmalloc_objs(*scheds,
+ rdev->num_cores,
+ GFP_KERNEL);
unsigned int core;
int ret;
@@ -543,7 +543,7 @@ static int rocket_ioctl_submit_job(struct drm_device *dev, struct drm_file *file
if (job->task_count == 0)
return -EINVAL;
- rjob = kzalloc(sizeof(*rjob), GFP_KERNEL);
+ rjob = kzalloc_obj(*rjob, GFP_KERNEL);
if (!rjob)
return -ENOMEM;
@@ -610,7 +610,7 @@ int rocket_ioctl_submit(struct drm_device *dev, void *data, struct drm_file *fil
return -EINVAL;
}
- jobs = kvmalloc_array(args->job_count, sizeof(*jobs), GFP_KERNEL);
+ jobs = kvmalloc_objs(*jobs, args->job_count, GFP_KERNEL);
if (!jobs) {
drm_dbg(dev, "Failed to allocate incoming job array\n");
return -ENOMEM;