diff options
| author | Michael Ellerman <mpe@ellerman.id.au> | 2022-04-07 00:57:59 +1000 |
|---|---|---|
| committer | Michael Ellerman <mpe@ellerman.id.au> | 2022-04-27 21:57:36 +1000 |
| commit | 0d897255e79e26f471d10bbf72db9eee6f9cb723 (patch) | |
| tree | 66cf81b9c266af07030ae02009ba30fd07289854 /drivers/macintosh/adbhid.c | |
| parent | 3527e1ab9a7990530dfb0137ddcfa64bed2915be (diff) | |
powerpc/85xx: Fix virt_to_phys() off-by-one in smp_85xx_start_cpu()
In smp_85xx_start_cpu() we are passed an address but we're unsure if
it's a real or virtual address, so there's a check to determine that.
The check has an off-by-one in that it tests if the address is greater
than high_memory, but high_memory is the first address of high memory,
so the check should be greater-or-equal.
It seems this has never been a problem in practice, but it also triggers
the DEBUG_VIRTUAL checks in __pa() which we would like to avoid. We can
fix both issues by converting high_memory - 1 to a physical address and
testing against that.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220406145802.538416-3-mpe@ellerman.id.au
Diffstat (limited to 'drivers/macintosh/adbhid.c')
0 files changed, 0 insertions, 0 deletions
