diff options
| author | Wentao Liang <vulab@iscas.ac.cn> | 2026-09-17 10:13:47 +0000 |
|---|---|---|
| committer | Hans Verkuil <hverkuil+cisco@kernel.org> | 2026-09-23 14:54:50 +0200 |
| commit | f5863ea3f99265e5e297e3dcf0f47432fee2b8ac (patch) | |
| tree | b71c38def9c3c6f782ef9ee26a37694c431d9f67 /drivers/media/platform | |
| parent | b00fbdad64d4ea7d594bc67988c1722fe5b3be50 (diff) | |
media: vpif_display: Fix i2c adapter reference leak in vpif_probe()
vpif_probe() takes a reference to the i2c adapter with
i2c_get_adapter() and passes it to v4l2_i2c_new_subdev_board(),
which does not consume it, but the reference is never released, so
it is leaked both when the probe succeeds and when it fails after
the adapter has been acquired.
Release the reference with i2c_put_adapter() on the success path and
in the probe_subdev_out cleanup.
Fixes: e7332e3a552f ("V4L/DVB (12176): davinci/vpif_display: Add VPIF display driver")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
Diffstat (limited to 'drivers/media/platform')
| -rw-r--r-- | drivers/media/platform/ti/davinci/vpif_display.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/media/platform/ti/davinci/vpif_display.c b/drivers/media/platform/ti/davinci/vpif_display.c index 08877ae1513a..8bea1de6ccc8 100644 --- a/drivers/media/platform/ti/davinci/vpif_display.c +++ b/drivers/media/platform/ti/davinci/vpif_display.c @@ -1289,9 +1289,12 @@ static int vpif_probe(struct platform_device *pdev) if (err) goto probe_subdev_out; + i2c_put_adapter(i2c_adap); + return 0; probe_subdev_out: + i2c_put_adapter(i2c_adap); kfree(vpif_obj.sd); vpif_unregister: v4l2_device_unregister(&vpif_obj.v4l2_dev); |