diff options
| author | Daniel Golle <daniel@makrotopia.org> | 2026-03-30 23:52:09 +0100 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2026-03-31 19:16:31 -0700 |
| commit | e9abf1da0af3f787a03b249945e5ca726c1b8013 (patch) | |
| tree | cf6bbbfdd1b9dfa6229217e4d5cdf89ca1949a34 /drivers/net/dsa | |
| parent | 9229cb5a941c981633a79c9867f339c4589a9da9 (diff) | |
net: dsa: mxl862xx: cancel pending work on probe error
Call mxl862xx_host_shutdown() in case dsa_register_switch() returns
an error, so any still pending crc_err_work get canceled.
Fixes: a319d0c8c8ce ("net: dsa: mxl862xx: add CRC for MDIO communication")
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/3fd163f5bb88de426ca9847549f94b4296170ef0.1774911025.git.daniel@makrotopia.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/dsa')
| -rw-r--r-- | drivers/net/dsa/mxl862xx/mxl862xx.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/net/dsa/mxl862xx/mxl862xx.c b/drivers/net/dsa/mxl862xx/mxl862xx.c index 78eef639628a..af9b00b2d2c4 100644 --- a/drivers/net/dsa/mxl862xx/mxl862xx.c +++ b/drivers/net/dsa/mxl862xx/mxl862xx.c @@ -407,6 +407,7 @@ static int mxl862xx_probe(struct mdio_device *mdiodev) struct device *dev = &mdiodev->dev; struct mxl862xx_priv *priv; struct dsa_switch *ds; + int err; priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); if (!priv) @@ -428,7 +429,11 @@ static int mxl862xx_probe(struct mdio_device *mdiodev) dev_set_drvdata(dev, ds); - return dsa_register_switch(ds); + err = dsa_register_switch(ds); + if (err) + mxl862xx_host_shutdown(priv); + + return err; } static void mxl862xx_remove(struct mdio_device *mdiodev) |