diff options
author | Stefan Agner <stefan@agner.ch> | 2015-05-18 18:33:27 +0200 |
---|---|---|
committer | Max Krummenacher <max.krummenacher@toradex.com> | 2016-06-29 14:03:08 +0200 |
commit | 7c83cef87116c0b2aaaf867f406831643306d3d1 (patch) | |
tree | 247b1ea9cc07e97adcfc9bbf993f07852f7bb338 /drivers/net/enc28j60.c | |
parent | 4ee83828023d9fe6abbe47881d6fd3ae0e5e3c31 (diff) |
can: mcp251x: fix resume when device is downColibri_iMX6_LinuxImageV2.6Beta2_20160701Apalis_iMX6_LinuxImageV2.6Beta2_20160701
If a valid power regulator or a dummy regulator is used (which
happens to be the case when no regulator is specified), restart_work
is queued no matter whether the device was running or not at suspend
time. Since work queues get initialized in the ndo_open callback,
resuming leads to a NULL pointer exception.
Reverse exactly the steps executed at suspend time:
- Enable the power regulator in any case
- Enable the transceiver regulator if the device was running, even in
case we have a power regulator
- Queue restart_work only in case the device was running
Fixes: bf66f3736a94 ("can: mcp251x: Move to threaded interrupts instead of workqueues.")
Signed-off-by: Stefan Agner <stefan@agner.ch>
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
(cherry picked from commit 25b401c1816ae64bcc5dcb1d39ab41812522a0ce)
Backport conflicts:
driver has been moved to spi subdir upstream
drivers/net/can/spi/mcp251x.c
Diffstat (limited to 'drivers/net/enc28j60.c')
0 files changed, 0 insertions, 0 deletions