diff options
| author | Minhong He <heminhong@kylinos.cn> | 2026-08-03 16:59:43 +0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2026-08-04 18:50:02 -0700 |
| commit | c1293e4a34e2db9f491f2509f812d5c999a2b002 (patch) | |
| tree | a50540418bfb2909a75c9ecbc1640ed988a0a409 /drivers/net/team | |
| parent | e43e9d7cabace0307685196114fc5d3ae6669120 (diff) | |
net: team: check register_netdevice_notifier() error in team_module_init()
team_module_init() ignores register_netdevice_notifier() errors and
continues module initialization, which can leave the team module loaded
without its netdev notifier registered.
Check the error and fail module initialization early.
This is a future looking check, register_netdevice_notifier()
only fails on double registration or if the registered notifier
itself returns an error.
Signed-off-by: Minhong He <heminhong@kylinos.cn>
Link: https://patch.msgid.link/20260803085943.142261-1-heminhong@kylinos.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/team')
| -rw-r--r-- | drivers/net/team/team_core.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/team/team_core.c b/drivers/net/team/team_core.c index feaa75fbf8fc..beffbe450612 100644 --- a/drivers/net/team/team_core.c +++ b/drivers/net/team/team_core.c @@ -3229,7 +3229,9 @@ static int __init team_module_init(void) { int err; - register_netdevice_notifier(&team_notifier_block); + err = register_netdevice_notifier(&team_notifier_block); + if (err) + return err; err = rtnl_link_register(&team_link_ops); if (err) |