diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2026-10-02 14:47:15 +0200 |
|---|---|---|
| committer | Linus Walleij <linusw@kernel.org> | 2026-10-02 23:46:48 +0200 |
| commit | b89f7dd31aa319b2e9a8c50ee7d4755031fecce6 (patch) | |
| tree | c36829d10bd0deaaf07a4392671f584e3adef9dc /drivers/pinctrl | |
| parent | 06a4459733daf58d983e59bc2a72aa5ff39fa6d9 (diff) | |
pinctrl: starfive: fix missing CONFIG_OF dependencies
The common driver portion requires CONFIG_OF, but the drivers
selecting it do not, so we get random warnings:
WARNING: unmet direct dependencies detected for PINCTRL_STARFIVE_JHB100
Depends on [n]: PINCTRL [=y] && OF [=n]
Selected by [y]:
- PINCTRL_STARFIVE_JHB100_PER1 [=y] && PINCTRL [=y] && (ARCH_STARFIVE || COMPILE_TEST [=y])
- PINCTRL_STARFIVE_JHB100_PER2POK [=y] && PINCTRL [=y] && (ARCH_STARFIVE || COMPILE_TEST [=y])
- PINCTRL_STARFIVE_JHB100_SYS1 [=y] && PINCTRL [=y] && (ARCH_STARFIVE || COMPILE_TEST [=y])
Selected by [m]:
- PINCTRL_STARFIVE_JHB100_PER0 [=m] && PINCTRL [=y] && (ARCH_STARFIVE || COMPILE_TEST [=y])
- PINCTRL_STARFIVE_JHB100_SYS0 [=m] && PINCTRL [=y] && (ARCH_STARFIVE || COMPILE_TEST [=y])
Apparently the problem is selecting CONFIG_OF_GPIO, which is a mistake
the newly added driver copied from others. This was recently cleaned up
with commit e785c990adcc ("pinctrl: Kconfig: drop unneeded dependencies
on OF_GPIO"). Do the same here for consistency and to avoid the warning.
Fixes: 9c4d0c8fc4c1 ("pinctrl: starfive: Add StarFive JHB100 sys0 controller driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Changhuang Liang <changhuang.liang@starfivetech.com>
Signed-off-by: Linus Walleij <linusw@kernel.org>
Diffstat (limited to 'drivers/pinctrl')
| -rw-r--r-- | drivers/pinctrl/starfive/Kconfig | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/pinctrl/starfive/Kconfig b/drivers/pinctrl/starfive/Kconfig index 11bd429b45b7..7ff506a15dd8 100644 --- a/drivers/pinctrl/starfive/Kconfig +++ b/drivers/pinctrl/starfive/Kconfig @@ -50,11 +50,9 @@ config PINCTRL_STARFIVE_JH7110_AON config PINCTRL_STARFIVE_JHB100 bool - depends on OF select GENERIC_PINCTRL select GPIOLIB select GPIOLIB_IRQCHIP - select OF_GPIO config PINCTRL_STARFIVE_JHB100_PER0 tristate "StarFive JHB100 SoC Peripheral-0 pinctrl and GPIO driver" |