diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2021-03-01 17:04:04 +0100 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2021-03-08 11:33:39 +0100 |
| commit | 2b329f5694aec86107931584413c7d2ebc6b548d (patch) | |
| tree | bef3934baddef03a5a3775f7bd4aaf9915b36b6c /drivers/platform/x86/intel-wmi-sbl-fw-update.c | |
| parent | 2478907572fdd7cf285720f16513e956b3528854 (diff) | |
platform/x86: wmi: Make remove callback return void
The driver core ignores the return value of struct bus_type::remove()
(and so wmi_dev_remove()) because there is only little that can be done.
To simplify the quest to make this function return void, let struct
wmi_driver::remove() return void, too. All implementers of this callback
return 0 already and this way it should be obvious to driver authors
that returning an error code is a bad idea.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Pali Rohár <pali@kernel.org>
Link: https://lore.kernel.org/r/20210301160404.1677064-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers/platform/x86/intel-wmi-sbl-fw-update.c')
| -rw-r--r-- | drivers/platform/x86/intel-wmi-sbl-fw-update.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/platform/x86/intel-wmi-sbl-fw-update.c b/drivers/platform/x86/intel-wmi-sbl-fw-update.c index ea87fa0786e8..3c86e0108a24 100644 --- a/drivers/platform/x86/intel-wmi-sbl-fw-update.c +++ b/drivers/platform/x86/intel-wmi-sbl-fw-update.c @@ -117,10 +117,9 @@ static int intel_wmi_sbl_fw_update_probe(struct wmi_device *wdev, return 0; } -static int intel_wmi_sbl_fw_update_remove(struct wmi_device *wdev) +static void intel_wmi_sbl_fw_update_remove(struct wmi_device *wdev) { dev_info(&wdev->dev, "Slim Bootloader signaling driver removed\n"); - return 0; } static const struct wmi_device_id intel_wmi_sbl_id_table[] = { |