diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2021-05-09 19:22:33 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-07-14 16:56:33 +0200 |
| commit | 460bee90091ddeadc38837fbbd25e45b7cd695b2 (patch) | |
| tree | 1e3017cf1c260fbc36f97c7d185b32e1961c88a2 /drivers/tty/nozomi.c | |
| parent | f5186bd17f3b37a7b6c85da5c0b6acb8d29ed264 (diff) | |
tty: nozomi: Fix a resource leak in an error handling function
[ Upstream commit 31a9a318255960d32ae183e95d0999daf2418608 ]
A 'request_irq()' call is not balanced by a corresponding 'free_irq()' in
the error handling path, as already done in the remove function.
Add it.
Fixes: 9842c38e9176 ("kfifo: fix warn_unused_result")
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/4f0d2b3038e82f081d370ccb0cade3ad88463fe7.1620580838.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/tty/nozomi.c')
| -rw-r--r-- | drivers/tty/nozomi.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c index d42b854cb7df..9a251a1b0d00 100644 --- a/drivers/tty/nozomi.c +++ b/drivers/tty/nozomi.c @@ -1436,6 +1436,7 @@ err_free_tty: tty_unregister_device(ntty_driver, dc->index_start + i); tty_port_destroy(&dc->port[i].port); } + free_irq(pdev->irq, dc); err_free_kfifo: for (i = 0; i < MAX_PORT; i++) kfifo_free(&dc->port[i].fifo_ul); |