summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorIan Abbott <abbotti@mev.co.uk>2026-01-30 16:47:37 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2026-04-02 15:49:37 +0200
commit9a27a33cd9b80a7304637356e8a5a9c5b846734f (patch)
tree9e2b103931bc78f87ab7994a283184dd988e8a0d /drivers
parent2750aecdf60524a7d58ecdaaa6e9728ad008cadb (diff)
comedi: das08_isa: Add sanity checks for I/O base address
The "das08_isa" driver uses an admin-supplied configuration option (`it->options[0]`) to configure the I/O port base address of a supported board in the DAS08 family. It currently allows any base address to be configured but the hardware only supports base addresses (configured by an on-board DIP switch) in the range 0 to 0x3f0 on 16-byte boundaries. (Technically, the DIP switches allow 8-byte boundaries, but I do not think that is advisable given that the boards decode an 16-byte address range.) Add a sanity check to ensure the device is not configured at an unsupported base address. Signed-off-by: Ian Abbott <abbotti@mev.co.uk> Link: https://patch.msgid.link/20260130170416.49994-13-abbotti@mev.co.uk Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/comedi/drivers/das08_isa.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/comedi/drivers/das08_isa.c b/drivers/comedi/drivers/das08_isa.c
index 3d43b77cc9f4..1b022dc10b78 100644
--- a/drivers/comedi/drivers/das08_isa.c
+++ b/drivers/comedi/drivers/das08_isa.c
@@ -167,7 +167,8 @@ static int das08_isa_attach(struct comedi_device *dev,
if (!devpriv)
return -ENOMEM;
- ret = comedi_request_region(dev, it->options[0], board->iosize);
+ ret = comedi_check_request_region(dev, it->options[0], board->iosize,
+ 0, 0x3ff, board->iosize);
if (ret)
return ret;