diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2026-03-06 16:07:34 +0100 |
|---|---|---|
| committer | Sebastian Reichel <sebastian.reichel@collabora.com> | 2026-03-11 07:58:43 +0100 |
| commit | c7e05ab38adc44d0cae4888016829359dcbba7b2 (patch) | |
| tree | f5d9eb35529424012376bbb1fb754b095758fe05 /drivers | |
| parent | 2cfc7cac68e19c4acb236b8db6065bbaff5deee8 (diff) | |
power: reset: reboot-mode: fix -Wformat-security warning
The device_create() function expects a format string to construct a device
name, so passing a variable here introduces a possible vulnerability in
case the string can contain '%' characters:
drivers/power/reset/reboot-mode.c:148:22: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
drivers/power/reset/reboot-mode.c:148:22: note: treat the string as an argument to avoid this
148 | (void *)priv, reboot->dev->driver->name);
Use an trivial "%s" format instead and pass the name as the string to be
included here.
Fixes: cfaf0a90789a ("power: reset: reboot-mode: Expose sysfs for registered reboot_modes")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://patch.msgid.link/20260306150738.497978-1-arnd@kernel.org
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/power/reset/reboot-mode.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/power/reset/reboot-mode.c b/drivers/power/reset/reboot-mode.c index ad239e96774b..d20e44db0532 100644 --- a/drivers/power/reset/reboot-mode.c +++ b/drivers/power/reset/reboot-mode.c @@ -145,7 +145,8 @@ static int reboot_mode_create_device(struct reboot_mode_driver *reboot) } priv->reboot_mode_device = device_create(&reboot_mode_class, NULL, 0, - (void *)priv, reboot->dev->driver->name); + (void *)priv, "%s", + reboot->dev->driver->name); if (IS_ERR(priv->reboot_mode_device)) { ret = PTR_ERR(priv->reboot_mode_device); goto error; |