summaryrefslogtreecommitdiff
path: root/fs
diff options
context:
space:
mode:
authorAl Viro <viro@zeniv.linux.org.uk>2026-01-06 23:30:02 -0500
committerAl Viro <viro@zeniv.linux.org.uk>2026-01-16 12:49:26 -0500
commit88fdc2761797ee7a537f92a84a4d4ac2e04436a4 (patch)
tree33daaba2284c92cf2a077d09943844e8cf2813c4 /fs
parentdc912db15ab19d366c56d34a4f06fe49334450b8 (diff)
non-consuming variant of do_mknodat()
similar to previous commit; replacement is filename_mknodat() Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs')
-rw-r--r--fs/init.c3
-rw-r--r--fs/internal.h2
-rw-r--r--fs/namei.c17
3 files changed, 11 insertions, 11 deletions
diff --git a/fs/init.c b/fs/init.c
index 9a550ba4802f..543444c1d79e 100644
--- a/fs/init.c
+++ b/fs/init.c
@@ -140,7 +140,8 @@ int __init init_stat(const char *filename, struct kstat *stat, int flags)
int __init init_mknod(const char *filename, umode_t mode, unsigned int dev)
{
- return do_mknodat(AT_FDCWD, getname_kernel(filename), mode, dev);
+ CLASS(filename_kernel, name)(filename);
+ return filename_mknodat(AT_FDCWD, name, mode, dev);
}
int __init init_link(const char *oldname, const char *newname)
diff --git a/fs/internal.h b/fs/internal.h
index 03638008d84a..02b5dec13ff3 100644
--- a/fs/internal.h
+++ b/fs/internal.h
@@ -60,7 +60,7 @@ int may_linkat(struct mnt_idmap *idmap, const struct path *link);
int filename_renameat2(int olddfd, struct filename *oldname, int newdfd,
struct filename *newname, unsigned int flags);
int filename_mkdirat(int dfd, struct filename *name, umode_t mode);
-int do_mknodat(int dfd, struct filename *name, umode_t mode, unsigned int dev);
+int filename_mknodat(int dfd, struct filename *name, umode_t mode, unsigned int dev);
int filename_symlinkat(struct filename *from, int newdfd, struct filename *to);
int filename_linkat(int olddfd, struct filename *old, int newdfd,
struct filename *new, int flags);
diff --git a/fs/namei.c b/fs/namei.c
index 21a2dbd8b9e6..ca524c5b18f4 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -5072,8 +5072,8 @@ static int may_mknod(umode_t mode)
}
}
-int do_mknodat(int dfd, struct filename *name, umode_t mode,
- unsigned int dev)
+int filename_mknodat(int dfd, struct filename *name, umode_t mode,
+ unsigned int dev)
{
struct delegated_inode di = { };
struct mnt_idmap *idmap;
@@ -5084,12 +5084,11 @@ int do_mknodat(int dfd, struct filename *name, umode_t mode,
error = may_mknod(mode);
if (error)
- goto out1;
+ return error;
retry:
dentry = filename_create(dfd, name, &path, lookup_flags);
- error = PTR_ERR(dentry);
if (IS_ERR(dentry))
- goto out1;
+ return PTR_ERR(dentry);
error = security_path_mknod(&path, dentry,
mode_strip_umask(path.dentry->d_inode, mode), dev);
@@ -5123,20 +5122,20 @@ out2:
lookup_flags |= LOOKUP_REVAL;
goto retry;
}
-out1:
- putname(name);
return error;
}
SYSCALL_DEFINE4(mknodat, int, dfd, const char __user *, filename, umode_t, mode,
unsigned int, dev)
{
- return do_mknodat(dfd, getname(filename), mode, dev);
+ CLASS(filename, name)(filename);
+ return filename_mknodat(dfd, name, mode, dev);
}
SYSCALL_DEFINE3(mknod, const char __user *, filename, umode_t, mode, unsigned, dev)
{
- return do_mknodat(AT_FDCWD, getname(filename), mode, dev);
+ CLASS(filename, name)(filename);
+ return filename_mknodat(AT_FDCWD, name, mode, dev);
}
/**