diff options
| author | Mukul Joshi <mukul.joshi@amd.com> | 2026-10-21 15:45:32 -0400 |
|---|---|---|
| committer | Alex Deucher <alexander.deucher@amd.com> | 2026-11-04 12:08:34 -0500 |
| commit | 05f51b3dedc1ea52422f65a2d948ee82feb9c6d5 (patch) | |
| tree | a2577afb5ed0533c9c5792fd05385602c642e5cc /include/linux/debugobjects.h | |
| parent | f5ea64f9fcd921bc4e2307a262e19450b8a58524 (diff) | |
drm/amdgpu: only tear down an active UALink accelerator
AMDGPU_UALINK_ACCEL_STATE_ERROR is ordered after ACTIVE, so the
"state < ACTIVE" check in deactivate_accelerator() lets an accelerator
in the error state through to the full teardown. The NPA VM and
workqueue are only created when the accelerator is activated, and an
accelerator in the error state either never got there (invalid pPod or
vPod configuration) or was already deactivated on the config update
error path.
Tearing it down again calls destroy_workqueue() on a NULL or freed
npa_wq and amdgpu_vm_fini() on an uninitialized or freed NPA VM. This
is reachable from driver unload (hw_fini), a later failing config
update, removal from the vPod and a pPod setup commit.
Only deactivate an accelerator that is actually active.
Fixes: 0e8eb0dcea51 ("drm/amdgpu: Assign accel state based on ASP config")
Signed-off-by: Mukul Joshi <mukul.joshi@amd.com>
Reviewed-by: Felix Kuehling <felix.kuehling@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit 0abb988dd7162e56e66e36c55780035be7d34b94)
Diffstat (limited to 'include/linux/debugobjects.h')
0 files changed, 0 insertions, 0 deletions
