summaryrefslogtreecommitdiff
path: root/include/linux/debugobjects.h
diff options
context:
space:
mode:
authorMani Tofigh <mt4022@columbia.edu>2026-11-05 15:32:12 -0500
committerMasami Hiramatsu (Google) <mhiramat@kernel.org>2026-11-09 09:31:11 +0900
commit0be7a931c5e41dcfdaf297f5cd34def2696b0a7e (patch)
tree41d0fb0552312db4f0894e8b63e38ce78f403e67 /include/linux/debugobjects.h
parentbe94710b1f6ba1bea33e73129c110af80e999b2d (diff)
kprobes: Disarm disabled optprobe on forced unoptimization
A disabled optimized probe can be freed with its int3 still in the text. It waits on the unoptimizing list for the optimizer to remove its jump. If another probe is armed on one of the bytes that jump replaced, unoptimize_kprobe() forces the unoptimization and moves the disabled probe straight to a cooling list without removing its int3: Task A (tracefs) Task B (optimizer) disable k1 /* k1 queued to unoptimize */ /* still on an earlier batch */ enable k2 on a byte k1's jump replaced unoptimize_kprobe(k1, true) /* int3 back, k1 on a cooling list */ remove k1 /* k1 freed, int3 left in the text */ The next call into the function then oopses: [ 9.924313] Oops: int3: 0000 [#1] SMP KASAN NOPTI [ 9.925627] CPU: 0 UID: 0 PID: 68 Comm: kprobeopt Tainted: G W 7.3.0-17087-gd865f2677c44 #1 PREEMPT [ 9.930933] RIP: 0010:__do_sys_sysinfo+0x8/0xe0 ... [ 9.949348] Call Trace: [ 9.949890] <TASK> [ 9.950404] do_syscall_64+0xfb/0x590 [ 9.952027] entry_SYSCALL_64_after_hwframe+0x77/0x7f ... [ 9.966436] </TASK> ... [ 9.968009] Kernel panic - not syncing: Fatal exception in interrupt Disarm a disabled probe on that path before it goes to the freeing or cooling list, like do_unoptimize_kprobes() does. With the fix, the int3 is gone by the time the probe is freed. This bug was identified and confirmed with the help of a deterministic hypervisor currently under development. The C reproducer below however hits it within about 10s. Link: https://lore.kernel.org/all/20261105-kprobes-optprobe-state-v2-1-7a2f5290baa0@columbia.edu/ Fixes: 06e0d3b89da1 ("kprobes: Make optprobe optimizer multi-generational and asynchronous") Signed-off-by: Mani Tofigh <mt4022@columbia.edu> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Diffstat (limited to 'include/linux/debugobjects.h')
0 files changed, 0 insertions, 0 deletions