diff options
| author | Maíra Canal <mcanal@igalia.com> | 2026-10-04 12:42:02 -0300 |
|---|---|---|
| committer | Maíra Canal <mcanal@igalia.com> | 2026-10-22 15:03:14 -0300 |
| commit | 8ef66514d7b993c9fb96a5886f001e3556610c1c (patch) | |
| tree | 3a048eb2d513bf8379aa66918df6179b9f5a53a9 /include/linux/debugobjects.h | |
| parent | 9ee552a42c3905b4547e83173d46413137ec329a (diff) | |
drm/vc4: Drop the BO reservations outside of job_lock
vc4_queue_submit() calls drm_exec_fini() with job_lock held and interrupts
disabled. Besides unlocking the reservations, drm_exec_fini() frees the
object array with kvfree(), which asks for preemptible task context or a
non-NMI interrupt, and may reach might_sleep() through vfree().
Considering that an array that exceeds a page can take the vmalloc
fallback, call drm_exec_fini() once job_lock is dropped. The reservations
are then held across the job kick, which is harmless as nothing in the
completion path takes a BO reservation.
Note that vc4_attach_fences() has to stay inside the critical section, as
it walks exec, which the job done worker is free to release as soon as
job_lock is dropped.
Cc: stable@vger.kernel.org
Fixes: 04630796c437 ("drm/vc4: Use DRM Execution Contexts")
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Link: https://patch.msgid.link/20261004-vc4-misc-fixes-v1-2-b763df9e33e1@igalia.com
Signed-off-by: Maíra Canal <mcanal@igalia.com>
Diffstat (limited to 'include/linux/debugobjects.h')
0 files changed, 0 insertions, 0 deletions
