diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2026-09-18 11:53:25 -0700 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2026-09-22 13:31:02 +0200 |
| commit | e3624f5eeac40e2f95e54e5ed684222438d56e23 (patch) | |
| tree | 483ed0796743d697913288fa68640aa6ce8fc29c /include/linux/debugobjects.h | |
| parent | 2d7341a020a57b30c1826db38f81bbc257ae3bbc (diff) | |
net: dsa: mv88e6xxx: check the port when reading back a policy rule
chip->policies is one IDR for the whole switch, so the location an
ETHTOOL_GRXCLSRULE caller supplies can name a rule belonging to any port.
mv88e6xxx_get_rxnfc() copies it out without looking at policy->port, which
lets a user on one user port read the MAC address and VID of a policy an
admin installed on another. ETHTOOL_GRXCLSRULE needs no CAP_NET_ADMIN.
The GRXCLSRLCNT and GRXCLSRLALL arms of the same switch statement already
filter on policy->port, which makes the GRXCLSRULE omission look
unintentional. Nonetheless, changing this does carry some regression
risk.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Link: https://patch.msgid.link/20260918185326.3940857-2-kuba@kernel.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'include/linux/debugobjects.h')
0 files changed, 0 insertions, 0 deletions