diff options
| author | Ovidiu Panait <ovidiu.panait.rb@renesas.com> | 2026-03-03 14:58:25 +0000 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2026-03-04 18:48:48 -0800 |
| commit | 35dfedce442c4060cfe5b98368bc9643fb995716 (patch) | |
| tree | 4f39d0906c3c4e0fcc85016079cf63c0bc913d5c /include/linux/rpmsg | |
| parent | 550921c67baa3669e108308b0d8cc9ee6471604b (diff) | |
net: stmmac: Fix error handling in VLAN add and delete paths
stmmac_vlan_rx_add_vid() updates active_vlans and the VLAN hash
register before writing the HW filter entry. If the filter write
fails, it leaves a stale VID in active_vlans and the hash register.
stmmac_vlan_rx_kill_vid() has the reverse problem: it clears
active_vlans before removing the HW filter. On failure, the VID is
gone from active_vlans but still present in the HW filter table.
To fix this, reorder the operations to update the hash table first,
then attempt the HW filter operation. If the HW filter fails, roll
back both the active_vlans bitmap and the hash table by calling
stmmac_vlan_update() again.
Fixes: ed64639bc1e0 ("net: stmmac: Add support for VLAN Rx filtering")
Signed-off-by: Ovidiu Panait <ovidiu.panait.rb@renesas.com>
Link: https://patch.msgid.link/20260303145828.7845-2-ovidiu.panait.rb@renesas.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'include/linux/rpmsg')
0 files changed, 0 insertions, 0 deletions
