diff options
| author | Olivier Louvignes <olivier@mgcrea.io> | 2026-10-26 09:33:23 +0100 |
|---|---|---|
| committer | Ulf Hansson <ulfh@kernel.org> | 2026-11-05 18:56:25 +0100 |
| commit | 6b8b1e8827837bf4cf1f87219038fddae9e81b0b (patch) | |
| tree | 19091db69d7ad227ebeab36d11e168972345f197 /include/linux/timerqueue.h | |
| parent | e35e360bd66898a977c296ab71fe4bae17ddceb7 (diff) | |
mmc: jz4740: Remove the host before resetting the controller
jz4740_mmc_remove() masks every interrupt and resets the controller
before mmc_remove_host(), which removes the card and lets the card's
driver send its last commands. Those commands then run on a controller
that was just reset, and can wait out the driver's 5 s request timeout.
With an SDIO card that cost 5 s on every unbind: on a HiBy R1 (Ingenic
X1600, a BCM43430A1 driven by brcmfmac), the CMD52 that
sdio_release_irq() sends from brcmfmac's remove waited 5.1 s. The
command had finished (END_CMD_RES set in MSC_STAT), but MSC_IMASK read
0xffffffff although the request had unmasked END_CMD_RES. MSC_STAT can
still show IS_RESETTING after jz4740_mmc_reset() returns, so the reset
most likely completed after that write and undid it.
Remove the host first, then quiesce the controller, as other host
drivers do. On the R1, unbinding the Wi-Fi's MSC now takes 0.65 s.
Fixes: 61bfbdb85687 ("MMC: Add support for the controller on JZ4740 SoCs.")
Cc: stable@vger.kernel.org
Signed-off-by: Olivier Louvignes <olivier@mgcrea.io>
Signed-off-by: Ulf Hansson <ulfh@kernel.org>
Diffstat (limited to 'include/linux/timerqueue.h')
0 files changed, 0 insertions, 0 deletions
