diff options
| author | David S. Miller <davem@davemloft.net> | 2020-03-16 02:04:24 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-03-16 02:04:24 -0700 |
| commit | 23c394819deb4eb642b60bbd5b3eef181e65cd8f (patch) | |
| tree | 50e6db43a35ff0a60dd39dda32e9d2a594502bb8 /include/linux | |
| parent | ef299cc3fa1a9e1288665a9fdc8bff55629fd359 (diff) | |
| parent | 2363d73a2f3e92787f336721c40918ba2eb0c74c (diff) | |
Merge branch 'ethtool-fail-with-error-if-request-has-unknown-flags'
Michal Kubecek says:
====================
ethtool: fail with error if request has unknown flags
Jakub Kicinski pointed out that if unrecognized flags are set in netlink
header request, kernel shoud fail with an error rather than silently
ignore them so that we have more freedom in future flags semantics.
To help userspace with handling such errors, inform the client which
flags are supported by kernel. For that purpose, we need to allow
passing cookies as part of extack also in case of error (they can be
only passed on success now).
====================
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/linux')
| -rw-r--r-- | include/linux/netlink.h | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/include/linux/netlink.h b/include/linux/netlink.h index 205fa7b1f07a..4090524c3462 100644 --- a/include/linux/netlink.h +++ b/include/linux/netlink.h @@ -119,6 +119,15 @@ static inline void nl_set_extack_cookie_u64(struct netlink_ext_ack *extack, extack->cookie_len = sizeof(__cookie); } +static inline void nl_set_extack_cookie_u32(struct netlink_ext_ack *extack, + u32 cookie) +{ + u32 __cookie = cookie; + + memcpy(extack->cookie, &__cookie, sizeof(__cookie)); + extack->cookie_len = sizeof(__cookie); +} + void netlink_kernel_release(struct sock *sk); int __netlink_change_ngroups(struct sock *sk, unsigned int groups); int netlink_change_ngroups(struct sock *sk, unsigned int groups); |