diff options
| author | Sanman Pradhan <psanman@juniper.net> | 2026-03-18 19:40:19 +0000 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2026-03-18 13:38:55 -0700 |
| commit | 86259558e422b250aa6aa57163a6d759074573f5 (patch) | |
| tree | ffa9162b2260e7f50f623b553272452318c7af70 /include/linux | |
| parent | 32f59301b9898c0ab5e72908556d553e2d481945 (diff) | |
hwmon: (pmbus/isl68137) Fix unchecked return value and use sysfs_emit()
isl68137_avs_enable_show_page() uses the return value of
pmbus_read_byte_data() without checking for errors. If the I2C transaction
fails, a negative error code is passed through bitwise operations,
producing incorrect output.
Add an error check to propagate the return value if it is negative.
Additionally, modernize the callback by replacing sprintf()
with sysfs_emit().
Fixes: 038a9c3d1e424 ("hwmon: (pmbus/isl68137) Add driver for Intersil ISL68137 PWM Controller")
Cc: stable@vger.kernel.org
Signed-off-by: Sanman Pradhan <psanman@juniper.net>
Link: https://lore.kernel.org/r/20260318193952.47908-2-sanman.pradhan@hpe.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'include/linux')
0 files changed, 0 insertions, 0 deletions