summaryrefslogtreecommitdiff
path: root/include/linux
diff options
context:
space:
mode:
authorHenry Hu <huhai@kylinos.cn>2026-09-03 19:30:46 +0800
committerJakub Kicinski <kuba@kernel.org>2026-09-07 17:20:19 -0700
commita4050ce7e46cecbc25eadfa89e4b907b1906a4f9 (patch)
tree8d52950305d03ae55f6afa4c245ba5a18b3ac636 /include/linux
parent6f157f39d1812ac5efd113a29bff3799dcb3150c (diff)
net: phy: microchip_t1: fix NULL pointer dereference in lan887x_phy_init()
The issue was discovered via smatch static analyzer: make CHECK="smatch -p=kernel" C=2 drivers/net/phy/microchip_t1.o CHECK scripts/mod/empty.c DESCEND objtool CHECK drivers/net/phy/microchip_t1.c drivers/net/phy/microchip_t1.c:1295 lan887x_phy_init() warn: 'priv->clock' can also be NULL mchp_rds_ptp_probe() returns NULL when CONFIG_MICROCHIP_PHY_RDS_PTP or CONFIG_PTP_1588_CLOCK is disabled. However, lan887x_phy_init() only checks for an error pointer before using the returned clock to configure the periodic output pin, which can result in a NULL pointer dereference. Handle the NULL return as PTP being unavailable and skip the event pin configuration in that case. Smatch no longer reports the NULL dereference warning after the change. Cc: stable+noautosel@kernel.org # untested fix to unlikely driver error path Reviewed-by: Divya Koppera <Divya.Koppera@microchip.com> Signed-off-by: Henry Hu <huhai@kylinos.cn> Link: https://patch.msgid.link/20260903113046.163630-1-15815827059@163.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'include/linux')
0 files changed, 0 insertions, 0 deletions